move aliases of highway=track from terms to aliases field
#470
Conversation
data/presets/highway/track.json
Outdated
| "unmaintained", | ||
| "woods road" | ||
| "unmaintained road", | ||
| "dirt road" |
There was a problem hiding this comment.
I'd like to keep terms sorted alphabetically. 🤓
There was a problem hiding this comment.
I didn't realize they were before. So, should I change this?
There was a problem hiding this comment.
iD ranks terms by their position in the list, so sorting them alphabetically promotes some rarer terms over more common terms. This might be less of a problem now that some terms are aliases, but it’s hard to test.
There was a problem hiding this comment.
Are you sure? Is this documented somewhere (+documented for translators)?
There was a problem hiding this comment.
Oh, either I’m mistaken or it’s no longer in place. It looks like nowadays iD only considers the index of a match against the preset name but only filters by terms.
Well, the problem here is that this property was never documented (see ideditor/schema-builder#28), nobody really knows. The most conservative approach would be to use |
|
Yeah... I will answer in ideditor/schema-builder#28 |
|
(FYI I consider this blocked until ideditor/schema-builder#28 came to a conclusion) |
see ideditor/schema-builder#28 (comment) – please only keep |
tyrasd
force-pushed
the
main
branch
2 times, most recently
from
9d3204d
to
49f529e
Compare
- add suggestions from @1ec5 - demote all except land-access road and track road to terms
|
Applied suggestions and #470 , ready for merge |
I would also have renamed the preset to
Land-Access Roadand movedTrack Roadto the aliases because with aliases, there is no need anymore to have any names with a/but since you just implemented interpreting thealiasesfield in iD, I guess you are aware of this possibility and had your reasons to keep it that way.See #288 (comment)